search

RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3
http://www.icedev.se
GNU General Public License v3.0
3.63k stars 981 forks source link

Added led order parameter (for Proxmark3 Easy board) #2299

Closed francesco-scar closed 4 months ago

francesco-scar commented 4 months ago

Added parameter LED_ORDER in Makefile.platform to correct led GPIO on Proxmark3 Easy board.

When setting LED_ORDER=PM3EASY, the LEDs get configured in the right order for this board, allowing correct binary counting of standalone modes and nice animations (SpinUp and SpinDown).

github-actions[bot] commented 4 months ago

You are welcome to add an entry to the CHANGELOG.md as well

iceman1001 commented 4 months ago

No sure why you swap in two places. Wouldn't armsrc/util.c be enough to swap the LED B/ D?

and ignore the the pin assignments ?

francesco-scar commented 4 months ago

I changed the definitions of the colors in armsrc/util.c just for completeness to match the colors on that specific board clone, where they apparently changed both the order and the colors (although they are not used anywhere).

I could have changed the "weights" of each LED in armsrc/util.h lines 45-48 to fix the order during the counting, but not the spin animations.

I think that this is a cleaner solution, so LED_A actually is defined as the LED marked A on the board, and so on

iceman1001 commented 4 months ago

Alright! Hope it works on the Pm3 easy.