RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3
http://www.icedev.se
GNU General Public License v3.0
3.63k stars 981 forks source link

Magic card docs editing #2302

Closed mishamyte closed 4 months ago

mishamyte commented 4 months ago

Some issues were found in the current doc.

Changes in that PR:

The main work is described above. If you have any comments/suggestions - pls, let me know.

github-actions[bot] commented 4 months ago

You are welcome to add an entry to the CHANGELOG.md as well

iceman1001 commented 4 months ago

Interesting,

I would say you remove too much information. This document isn't just about latest commands, but also in documenting the protocol used for magic cards.

mishamyte commented 4 months ago

No problem.

Are you talking about the USCUID section?

Cause I replaced my snippets of raw calls for getting the config for the standard commands. My point was that all raw commands are described in the general part of USCUID section and I was not sure should we copy them to the concrete one. I could also change the "Commands" section for the types of USCUID and add all commands from that type.

I think that was only replacements I made. Or I'm missing something?

iceman1001 commented 4 months ago

yeah, raw snippets and protocol bytes. In one case you replaced the config block with the another output in the broken down format. Copy paste problem I guess.

mishamyte commented 4 months ago

Gotcha!

Returned raw commands for corresponding tags and thank you for that copy-paste typo.

Pls, let me know if I should change/add something.

Thank you!

iceman1001 commented 4 months ago

All good,

Thanks!