search

RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3
http://www.icedev.se
GNU General Public License v3.0
3.63k stars 981 forks source link

hf mf dump print by default #2308

Closed francesco-scar closed 4 months ago

francesco-scar commented 4 months ago

Added dump print by default in hf mf dump and now supports the noprint flag to allow the same behavior as before. Also updated the changelog for past commits.

iceman1001 commented 4 months ago

Why would we have a no-printing ?

francesco-scar commented 4 months ago

I don't know, I was considering a scenario where you might only want to save the dump to a file and avoid lengthy printing; I wasn't sure if the previous behavior was desired or not. If you believe it's better, I can simply remove that option.

iceman1001 commented 4 months ago

Thanks for the interest and effort of making a PR, however I just don't see the purpose with this.

Closing.

francesco-scar commented 4 months ago

Okay, but can we just add a way to view the dumped data without saving it to a file? It's quite annoying to have to repeatedly execute two commands, saving to a file and then displaying its content, just to view the data. Additionally, without printing, I believe the --ns (no save) option is rather useless.

iceman1001 commented 4 months ago

We have hf mf view -h for viewing memory dump files.
We have hf mf dump for saving and print card memory We have hf mf dump --ns for viewing card memory

The use-case for saving only , I just don't see we need that.

francesco-scar commented 4 months ago

With the current code, the hf mf dump command doesn't print the card memory to the screen (correct me if I'm wrong).

iceman1001 commented 4 months ago

Hm...
and here I was certain the dump was printed like in the other dump commands.

I pushed a fix for that.

iceman1001 commented 4 months ago

Alright, now I see the reason for your PR, I already added your stuff, so I will close this PR, but you got mentioned in both CHANGELOG and Commit message.

Sorry for the convenience