Closed henrygab closed 4 months ago
Nice! Great reseach of yours. Well done indeed!
It will take me some time to read through but I will merge pretty soon :)
The command structure inside the em4x70 will need some refactoring to become like the rest of the client as you noted.
Sidenote,
The printandlogex can use the NOLF
when you don't want a linefeed
You also would need to add the changes in experimental_lib/CMakefiles
I do understand the use of assert, however it aborts the client and leaves you in the shell.
We have found that pattern to be annoying. We rather gracefully inform the user that the operation failed and they can continue in the pm3 shell.
Reconsider the use of assert.
Reconsider the use of assert.
OK, assertions are fully disabled for ID48LIB in the PM3 build.
You also would need to add the changes in experimental_lib/CMakefiles
Here, I am lost. Can you please help to make the required changes in experimental_lib/CMakefiles? If I am required to handle this directly, it will likely take many days.
:) No worries, easy merge
:) No worries, easy merge
Hah! Just that one line? I had looked at all the related libs, and how they had many conditional statements on being skipped, being found, ... I obviously overthought the difficulty of the addition needed. :) Thank you!
Well..
I was guessing your Cmakefile was working. if that was the case, some more testing is need to verify it all works, not just build
Relies on new dependency, id48lib.
After this is enabled, work can begin to validate
lf em 4x70 writekey
successfully wrote the requested key.Now uses smaller lookup tables to emulate output filter. No more 128k ROM/FLASH memory requirement, if adding id48lib to ARM binaries.