lf em 4x70 autorecover - Githubissues

henrygab commented 6 months ago

Add lf em 4x70 autorecover command

Also:

common.h: Increase safety of some of the macros. Parenthesizing the macro parameters ... a best practice.
firmware: partially-tracked source of "extra bits" messages. Add a TODO comment for further study.
Improve reliability of lf em 4x70 writekey Authenticate w/new key after it is written. Particularly important for glass modules, or other tags with weaker coupling.

iceman1001 commented 6 months ago

Nice one,

I see an issue with your setup doesn't have GD available and hence influence the make styleby removing waveshare.

Consider using setpin and setkey instead of writepin, writekey ,

henrygab commented 6 months ago

I see an issue with your setup doesn't have GD available and hence influence the make styleby removing waveshare.

Oh! That's unexpected! I didn't realize make style (at least for the documentation portions) would exclude options that are not built.

Is the documentation portion of make style something that can be automatically / periodically done within a github action? (to ensure it's always up-to-date, for example)
I've submitted PR #2328 as a manual fix.
I chose not to update the ID48LIB library sources manually ... is there a way to exclude that from make style altogether so others don't mess with it?

Consider using setpin and setkey instead of writepin, writekey ,

Just want to confirm ... are you asking me to modify the verbs? Even if breaking existing scripts?

I don't mind doing the work to do so, and so I'd be happy to do it. I just wanted to ensure you'd provide "air cover" if someone gets upset about my breaking their scripts.

Thanks!

iceman1001 commented 6 months ago

I don't think we thought the the change to GD dependency would be not installed by default on a OS.

If I knew, I wouldn't have approved the change.

You would need to look the make style commands in the makefile and see if you can make an exception for your lib.

Which existing scripts uses writepin or writekey ? When I search the repo there is not any hits in a script.

henrygab commented 6 months ago

Which existing scripts uses writepin or writekey ? When I search the repo there is not any hits in a script.

None that are checked in. Let me know either way, I'm happy to adjust to your preferences.

iceman1001 commented 6 months ago

Since we have no issue with repo, please adjust to the suggested new command names

RfidResearchGroup / proxmark3

lf em 4x70 autorecover #2327