RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3
http://www.icedev.se
GNU General Public License v3.0
3.62k stars 979 forks source link

Decoder must not write more bit than requested #2331

Closed henrygab closed 3 months ago

henrygab commented 3 months ago

Fixes the following error messages when using em4x70 tags:

[#] Should have a multiple of 8 bits, was sent 65
[#] Should have a multiple of 8 bits, was sent 33

The underlying issue is that the manchester decoder was writing one extra bit of data when reading certain tag data. (the buffer happened to always be larger than necessary, so did not happen to corrupt data)

To repro the problem behavior: lf em 4x70 --block 12 --data 0xAAAA lf em 4x70 --block 0 --data 8765

github-actions[bot] commented 3 months ago

You are welcome to add an entry to the CHANGELOG.md as well

iceman1001 commented 3 months ago

Nice fix, And we still have a bug in the manchester decoder. check.