search

RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3
http://www.icedev.se
GNU General Public License v3.0
3.62k stars 979 forks source link

Upgrade SWIG to 4.2.0 for Python 3.12 support ? #2350

Closed philicious closed 2 months ago

philicious commented 2 months ago

Describe the bug With

Python3 library: Python3 v3.12 found, enabled

you cannot compile and get errors

ld: Undefined symbols:
  _PyArg_UnpackTuple, referenced from:
      _SwigPyObject_own in pm3_pywrap.o
  _PyBool_FromLong, referenced from:
...
alot more lines

The pm3_pywrap.c and pm3_luawrap.c files were generated with SWIG 4.0.2 as header comments suggests. SWIG 4.2.0 brings support for Python 3.12, according to https://www.swig.org/Release/RELEASENOTES

Thats also likely the reason for https://github.com/RfidResearchGroup/proxmark3/issues/2305

philicious commented 2 months ago

interestingly its building against Python 3.12 using cmake instead of make. so its probably some bad or missing config in Makefile

iceman1001 commented 2 months ago

I updated the swig to 4.2.1 ...
Now its down to testing if the experimental lib/client works :)