search

RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3
http://www.icedev.se
GNU General Public License v3.0
3.62k stars 979 forks source link

Fix OOB segfault with markers #2373

Closed jlitewski closed 1 month ago

jlitewski commented 2 months ago

This fixes an issue that was found by gentilkiwi. I added bounds checking to the marker placing code. I also modified it to run only when a left/right mouse click was made, instead of doing all the math every time the Plot::MouseMoveEvent() function was called and then only applying it if there was a mouse click.

github-actions[bot] commented 2 months ago

You are welcome to add an entry to the CHANGELOG.md as well

iceman1001 commented 1 month ago

Nice! No need to recalc everything with mouse move event indeed

btw Only need to fix the if-statement style.