RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3
http://www.icedev.se
GNU General Public License v3.0
3.62k stars 979 forks source link

Felica raw command select key fix #2412

Open RebornedBrain opened 4 days ago

RebornedBrain commented 4 days ago

Problem:

Currently when using hf felica raw command with flag -s it fails because of the CRC check during command reception. image But if then we take a look into hf felica list, we can see that in fact it receives correct data: image The reason of that, is that when -s flag is used firmware side calls felica_select_card which selects a card and copies all the data to felica_card_select_t which then is transmitted to client. And then when client tries to check CRC it fails, because it expects raw frame for that check.

Solution:

This fix changes the logic so felica_select_card on the firmware side returns a raw frame to client, which then is able to check CRC correctly. Also it required to change 'read_felica_uid' on the client side, now it copies required data from raw bytes to felica_card_select_t.

github-actions[bot] commented 4 days ago

You are welcome to add an entry to the CHANGELOG.md as well