search

RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3
http://www.icedev.se
GNU General Public License v3.0
3.85k stars 1.02k forks source link

Travis CI on MacOSX does not checkout the proper branch #332

Closed doegox closed 5 years ago

doegox commented 5 years ago

See e.g. https://travis-ci.org/RfidResearchGroup/proxmark3/jobs/572902998 which should have failed building branch makefile_restruct but instread succeeded in building branch master

I guess the brew mechanism fetches unconditionally the master.

Now I understand why a previous PR which was apparently ok, broke stuffs once merged...

iceman1001 commented 5 years ago

@merlokk our CI expert...

merlokk commented 5 years ago

i think problem is here brew install --HEAD proxmark3 ill look how to fix

iceman1001 commented 5 years ago

We would need to compile two versions on Travis CI for OSX. With and without BT support.

brew install --HEAD proxmark3
brew install --with-blueshark proxmark3
iceman1001 commented 5 years ago

I also think it needs to be like this, but not sure

brew install --HEAD --with-blueshark proxmark3
doegox commented 5 years ago

It would be far easier if Brew was like ProxSpace: only responsible to provide the environment. Then we take over as usual with git/make instructions. So no need for magic tricks to get BT support, to fetch a branch, to let Travis testing the branch and the PR (so the merge of the branch in master), etc. And when we're starting to work on the make install, we can have make install running on MacOSX too, without relying on Brew and being tied to the brew formula expectations in terms of directories etc.

merlokk commented 5 years ago

there was an idea that brew can be used by users to have proxmark installed. i'd prefer that we have sh file to get and make, but maybe it will be better to fix current system. ill try and lets see.

RfidResearchGroup commented 5 years ago

Thanks @Merlokk . I added you and @doegox as collabs to that repo so you can merge PRs :) Also changed some textual things and removed old directives of hid-flasher.

merlokk commented 5 years ago

now it looks it works with branches, but not works with PR's @doegox if you have changes to repo - check please branches testing (i dont want to make strange commits)

merlokk commented 5 years ago

ok. it works with branches.

merlokk commented 5 years ago
  1. make work my script for osx
  2. PR compiling. maybe fully get rid of brew install and move logic to plain make all (needs to think how to debug brew install or just let it work wo this)
  3. make compile matrix to check some modes (now for btaddon)
iceman1001 commented 5 years ago

time to close?

doegox commented 5 years ago

ok