RfidResearchGroup / proxmark3

Iceman Fork - Proxmark3
http://www.icedev.se
GNU General Public License v3.0
4.03k stars 1.06k forks source link

HELP_EXAMPLE_STANDALONE causes confusing output #375

Closed ZeroChaos- closed 5 years ago

ZeroChaos- commented 5 years ago

The HELP_EXAMPLE bits are a bit mismatched:

armsrc/Standalone/Makefile.hal:HELP_EXAMPLE_STANDALONE=HF_COLIN
common_arm/Makefile.hal:make PLATFORM=PM3OTHER STANDALONE=$(HELP_EXAMPLE_STANDALONE)

Producing this:

zero@theprophet proxmark3 % make PLATFORM=                                                                                                                                    (git)-[master] 
common_arm/Makefile.hal:64: *** Invalid or empty PLATFORM: . 
Known definitions:

+============================================+
| PLATFORM        | DESCRIPTION              |
+============================================+
| PM3RDV4 (def)   | Proxmark3 rdv4           |
...
snip
...
Options to define platform, platform extras and/or standalone mode:
(1) Run make with your PLATFORM, PLATFORM_EXTRAS and/or STANDALONE choices as follows:
make PLATFORM=PM3OTHER STANDALONE=HF_COLIN
...
snip
ZeroChaos- commented 5 years ago

I'd suggest changing HELP_EXAMPLE_STANDALONE to something that works for PM3OTHER just to avoid the confusion of the sample not working

iceman1001 commented 5 years ago

Good thing the makefile stopped :)
Fixed it

doegox commented 5 years ago

good catch!