iceman1001
commented
4 years ago yeah. hitag2 / hitagS the bad child. They basically took hitag2 made a copy and adapted it to S.. So it takes a huge space and full of legacy code.
Open doegox opened 4 years ago
iceman1001
commented
4 years ago yeah. hitag2 / hitagS the bad child. They basically took hitag2 made a copy and adapted it to S.. So it takes a huge space and full of legacy code.
There are many (23) bad operations flagged in HitagS code by coverity It seems they've been solved in the official repo, at least for the parts I looked at (https://github.com/Proxmark/proxmark3/pull/721/files#diff-589b396aa9cc54b383991e0b312a9950R1053-R1057)
See the massive PR https://github.com/Proxmark/proxmark3/pull/721