RhenaudTheLukark / CreateYourFrisk

Rhenaud The Lukark's Unitale fork
GNU General Public License v3.0
132 stars 56 forks source link

text command [func} is always called from encounter script, not source script #116

Closed CheBuRex closed 1 year ago

CheBuRex commented 1 year ago

In my case it was used in HandleCustomCommand in enemy script but it was calling the function from encounter script

image

CheBuRex commented 1 year ago

ik that it's unstable build but i think i should to report a bug, shouldn't i?

RhenaudTheLukark commented 1 year ago

If you used [func] in a text in the BattleDialog() function, then [func] will call the function in the script the arena text object belongs to, which is the Encounter script!

CheBuRex commented 1 year ago

Oh, ok. I just was wondering because in LTS2 it was behaving differently.

RhenaudTheLukark commented 1 year ago

Was it now? With BattleDialog()? That seems more like a LTS2 error than anything to me, I'll check that on my end.

CheBuRex commented 1 year ago

Yes, it was calling function from source script when used in BattleDialog()

RhenaudTheLukark commented 1 year ago

You would be right! I will jolt that down and add it to my TODO list! Will close and cite this issue when it's done! Thanks for the feedback!

RhenaudTheLukark commented 1 year ago

The latest commit should fix this issue, a new version of CYF with those latest changes should spring up in about 10m, feel free to check it out and close this issue if the problem's gone!