search

RhenaudTheLukark / CreateYourFrisk

Rhenaud The Lukark's Unitale fork
GNU General Public License v3.0
133 stars 56 forks source link

Text Objects ignore [noskip] for 1 frame #18

Closed Eir-nya closed 6 years ago

Eir-nya commented 6 years ago

Description When using a text object whose next line of text begins with [noskip], the player can still skip that line of text for 1 frame as it is appearing. [instant:stopall] does not fix it, either.

To Reproduce Steps to reproduce the behavior:

  1. Go to any mod, or create a new mod for testing
  2. Create a text object with multiple strings of text
  3. Begin each string with [noskip]
  4. Start the mod in CYF, and hit X and Shift as fast as possible when the text is changing
  5. With some luck, you should be able to skip the text, even though [noskip] was there!

Expected behavior [noskip] should prevent the Player from skipping text like this, like it does for BattleDialog and monster text.

Setup: Windows x64 CYF v0.6.1.2 Mod: any

RhenaudTheLukark commented 6 years ago

CYF has a lot of 1-frame errors, with for example the PP Collision system checking for collision one frame late. Fixing this has chances to make me remake the whole system, so I surely won't fix it.

RhenaudTheLukark commented 6 years ago

However, if someone wants to go through the code and try to fix it by themselves, feel free to try!

RhenaudTheLukark commented 6 years ago

Fixed with the commit above.