RhenaudTheLukark / CreateYourFrisk

Rhenaud The Lukark's Unitale fork
GNU General Public License v3.0
133 stars 56 forks source link

[Issue] Incorrect documentation of [speed] and issues with it #37

Closed TomaszewskiPatryk closed 5 years ago

TomaszewskiPatryk commented 5 years ago

Describe the issue The documentation states that: image However, when at [speed:1], 1 character is being displayed, but every 4 frames.

Consequences Now, it's not only a mistake in the documention. This has some pretty far going consequences. Firstly, setting speed to 2 doesn't make it display 1 character every 2 frames, but instead displays 2 characters every 4 frames, making the text less smooth. Secondly, since [speed] can only use integers, precision of it is significantly decreased (it actually makes it impossible to match the exact text speed of Deltarune). It's also worth noting that, since text speed can't be lower than 1, making the text display slower than normally is only obtainable by putting [w] between every character.

Final notes Similiar problems would occur with [letters], since it also displays n characters per "frame". That means that any fixes for [speed] should also be applied to [letters].

Setup:

Eir-nya commented 5 years ago

It's true that the "speed" command deserves a re-write in the documentation, and it needs to be changed from "x characters every 4 frames" to "1 character every x frames".

But I'm just commenting to give you a little warning: most likely, Deltarune doesn't actually run with a non-whole number text speed. Think about it, it would make no sense to have every few letters skip ahead one. When I was remaking the Sans fight, I thought that Undertale had a non-whole number text speed, but it was actually that my gif recorder kept skipping every few frames of gameplay. I believe that's most likely what you are experiencing here.

TomaszewskiPatryk commented 5 years ago

What I was referring to was that it runs faster than speed 1 (1 character every 4 frames) and slower than speed 2 (1 character every 2 frames), meaning it displays 1 character every 3 frames, which in current speed notation would be 1.5.

RhenaudTheLukark commented 5 years ago

Fixed in 0.6.2.2