search

RhetTbull / osxphotos

Python app to work with pictures and associated metadata from Apple Photos on macOS. Also includes a package to provide programmatic access to the Photos library, pictures, and metadata.
MIT License
2.17k stars 100 forks source link

exporting a video with missing edited file causes missing path to be skipped #1380

Open RhetTbull opened 10 months ago

RhetTbull commented 10 months ago

The elif block in this code in export_cli is not needed and causes the "missing" processing to be skipped. The original gets downloaded but there's no attempt to export the edited version and it's not added to the missing count.

    # slow_mo photos will always have hasadjustments=True even if not edited
    if photo.hasadjustments and photo.path_edited is None:
        if photo.slow_mo:
            export_original = True
            export_edited = False
        elif not download_missing:
            # requested edited version but it's missing, download original
            export_original = True
            export_edited = False
            verbose(
                f"Edited file for [filename]{photo.original_filename}[/] is missing, exporting original"
            )
RhetTbull commented 10 months ago

See also #1379