search

RhetTbull / osxphotos

Python app to work with pictures and associated metadata from Apple Photos on macOS. Also includes a package to provide programmatic access to the Photos library, pictures, and metadata.
MIT License
1.76k stars 93 forks source link

Add 12310 model support #1485

Closed axelkar closed 2 months ago

axelkar commented 2 months ago

It's seen on an iPad running iOS 12.5.7 (16H81)

Tracking issue: #1483

Schema: https://gist.github.com/axelkar/29bc127ba6d8347768c733636fe5481d

This is marked as draft since I don't think I'm using a clean way of checking the version.

axelkar commented 2 months ago

Is there a way to skip CI when making draft PRs?

RhetTbull commented 2 months ago

@axelkar >Is there a way to skip CI when making draft PRs?

If you include [skip ci] in the commit message, it should skip running CI. Not sure about PRs though.

RhetTbull commented 2 months ago

Hi @axelkar thanks much for the work on this PR. Unfortunately I don't plan to incorporate it at this time. This adds complexity and maintenance burden to the code to support one very specific version of an old database. Not many people are still using iOS 12 and very few people use osxphotos with iOS as this isn't a practical use case for osxphotos (though it can read modern iOS libraries). I've put the schema in the osxphotos wiki so that if I ever go back and add support for older iOS versions, I can do that.

The primary reason osxphotos supports older version on macOS is I started development of osxphotos on 10.12 and as I've upgraded my machines, I've also updated osxphotos. But that also means I have access to test libraries for each supported version, which I don't for iOS. I rigorously test osxphotos (over 1000 tests) with each release to ensure I don't break anything and I wouldn't be able to do that for old versions of iOS.