Edited iPhone screenshots are not grouped properly

RhetTbull / osxphotos

Python app to work with pictures and associated metadata from Apple Photos on macOS. Also includes a package to provide programmatic access to the Photos library, pictures, and metadata.

MIT License

2.17k stars 100 forks source link

Edited iPhone screenshots are not grouped properly #1656

Open arthurward opened 3 months ago

arthurward commented 3 months ago

When importing an iPhone screenshot consisting of IMG_1234.PNG, IMG_1234.AAE, and IMG_E1234.jpeg, osxphotos decides that the AAE file is not an Apple Photos file and ungroups the files. The root cause is that the screenshot editor sets the AAE file's "adjustmentFormatIdentifier" to "ScreenshotServices".

Here is an example: IMG_6743.zip

RhetTbull commented 3 months ago

@all-contributors please add @arthurward for bug

allcontributors[bot] commented 3 months ago

@RhetTbull

I've put up a pull request to add @arthurward! :tada:

RhetTbull commented 3 months ago

Thanks for the test data. Will work to get this incorporated when I have time. This should be an easy fix. The check for import is done in a single function that can be modified:

https://github.com/RhetTbull/osxphotos/blob/23e3c995f81eb849f69dc241b6c1d0486f599334/osxphotos/image_file_utils.py#L118-L123