osxphotos export error when'd destination folder becomes empty when using --ramdb --cleanup --update [low priority]

[oPromessa]

Before submitting a bug report, please ensure you are running the most recent version of osxphotos and that the bug is reproducible on the latest version

osxphotos, version 0.68.5
Python 3.11.5 (main, Aug 24 2023, 15:23:30) [Clang 14.0.0 (clang-1400.0.29.202)]
macOS 12.7.6, x86_64

Describe the bug

• Not a major issue as it pertains to a very specific outlier case ;)
• osxphotos export error when'd destination folder becomes empty when using --ramdb --cleanup --update
• The key being --ramdboption:
  • with it: it crashes as it tries to write .osxphotos_export.db into the export folder, which is no longer there (was deleted via the --update/--cleanup options)
  • without it: it does not crash as --update/--cleanup do not delete the folder given they see .osxphotos_export.db file in it.

To Reproduce

• Run an export command which results in 0 pics being exported without ramdb

• Without --ramdb

  $ rm -fr bursts ; mkdir -p bursts && caffeinate osxphotos export bursts --update --cleanup  --to-date "2015-12-22T23:59:59" --library /Users/XXX/Pictures/Import.NAS2Library.photoslibrary/ 
  (...)
  $  ls -a bursts/
  .           ..          .osxphotos_export.db

• With --ramdb

  $  rm -fr bursts ; mkdir -p bursts && caffeinate osxphotos export bursts --ramdb --update --cleanup  --to-date "2015-12-22T23:59:59" --library /Users/XXX/Pictures/Import.NAS2Library.photoslibrary/ 
  (...)
  Did not find any photos to export
  Cleaning up /Users/XXX/Documents/GitHub/Export/recreate/bursts
  Deleted: 0 files, 1 directory
  Something went wrong and osxphotos encountered an error:
  RetryError[<Future at 0x118056fd0 state=finished raised OperationalError>]
  Writing export database to /Users/XXX/Documents/GitHub/Export/recreate/bursts/.osxphotos_export.db
  ╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
  │ /Users/XXX/Documents/Apps/osxphotos/venv3.11/lib/python3.11/site-packages/tenacity/__init__.py:3 │
  │ 82 in __call__                                                                                   │
  │                                                                                                  │
  │   379 │   │   │   do = self.iter(retry_state=retry_state)                                        │
  │   380 │   │   │   if isinstance(do, DoAttempt):                                                  │
  │   381 │   │   │   │   try:                                                                       │
  │ ❱ 382 │   │   │   │   │   result = fn(*args, **kwargs)                                           │
  │   383 │   │   │   │   except BaseException:  # noqa: B902                                        │
  │   384 │   │   │   │   │   retry_state.set_exception(sys.exc_info())  # type: ignore[arg-type]    │
  │   385 │   │   │   │   else:                                                                      │
  │                                                                                                  │
  │ /Users/XXX/Documents/Apps/osxphotos/venv3.11/lib/python3.11/site-packages/osxphotos/export_db.py │
  │ :1189 in write_to_disk                                                                           │
  │                                                                                                  │
  │   1186 │   │   │   │   sqlite_delete_dbfiles(self._dbfile)                                       │
  │   1187 │   │   │                                                                                 │
  │   1188 │   │   │   # write the new database to disk                                              │
  │ ❱ 1189 │   │   │   conn_on_disk = sqlite3.connect(                                               │
  │   1190 │   │   │   │   str(self._dbfile), check_same_thread=SQLITE_CHECK_SAME_THREAD             │
  │   1191 │   │   │   )                                                                             │
  │   1192 │   │   │   conn.backup(conn_on_disk, pages=1)                                            │
  ╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
  (...)
  $ ls -a bursts
  ls: bursts: No such file or directory

Expected behavior No crash. Either:

• keep the destination folder with the .osxphotos_export.db file in it -- could be good to save historical info from the DB.
• or remove the destination folder entirely without an error.

Screenshots N/A

Desktop (please complete the following information):

osxphotos, version 0.68.5
Python 3.11.5 (main, Aug 24 2023, 15:23:30) [Clang 14.0.0 (clang-1400.0.29.202)]
macOS 12.7.6, x86_64

Additional context N/A

[RhetTbull]

Interesting -- I think the real issue is that osxphotos deleted the export directory with --cleanup if it was empty (nothing exported), which it should not do.

[oPromessa]

Yes. And possibly is a cleaner and easier solution yes.