Add `--signature` to `osxphotos sync`

RhetTbull / osxphotos

Python app to work with pictures and associated metadata from Apple Photos on macOS. Also includes a package to provide programmatic access to the Photos library, pictures, and metadata.

MIT License

2.17k stars 100 forks source link

Add `--signature` to `osxphotos sync` #1740

Open RhetTbull opened 1 day ago

RhetTbull commented 1 day ago

See #1738

Implement the same signature template used in osxphotos import

oPromessa commented 1 day ago

Looking at photo_signature function code I noticed it generates a new fingerprint from the file on disk when:

photo.fingerprint is not defined
we're on MacOs

So maybe adding an option on "sync export" to --update-signature-from-file (or a better name) to re-calculate all fingerprints on "sync export" would do the trick?

Would this make sense?

https://github.com/RhetTbull/osxphotos/blob/4f7895cd20bdacf8c088c01f19f2a60ef11bdd1c/osxphotos/photo_signature.py#L17-L36

RhetTbull commented 19 hours ago

This would work but only for photos that are present on disk. If the photos is missing (not downloaded from iCloud) this would fail.