RhetTbull
commented
2 years ago Great debug info -- thanks! My first guess would've been photoinfo was changing (labels are sometimes re-computed by Photos) but your step 6 above shows that's not the case.
Does the file 1969-11-09-1.jpg always get re-exported? If so, that'll make tracking this down easier.
How familiar are you with the python debugger? I've built debugger access into the current github version (not yet released) so if you're comfortable trying a bleeding edge feature, you can use your clone of osxphotos, do a git pull, then try the following:
OSXPHOTOS_IS_TESTING=1 python3 -m osxphotos export /Volumes/photo-1/(...) --exportdb ./.osxphotos_export.db --load-config ./colibri.toml --name "1969-11-09-1" --breakpoint osxphotos.photoexporter.PhotoExporter._should_update_photo
That will drop you into the debugger when osxphotos is about to call the _should_update_photo method to determine if the photo should be updated. Hit s to step into the the _should_update_photo then n to step through each of the tests to see which test is returning True. Here's an example where I added a keyword forcing the exiftool check to return True:
⇣41% [I] ➜ OSXPHOTOS_IS_TESTING=1 python3 -m osxphotos export ~/Desktop/export --exiftool --touch-file --update --name 3092 --breakpoint osxphotos.photoexporter.PhotoExporter._should_update_photo
Breakpoint added for osxphotos.photoexporter.PhotoExporter._should_update_photo
Using last opened Photos library: /Users/rhet/Pictures/Test-10.15.7.photoslibrary
Exporting 1 photo to /Users/rhet/Desktop/export...
[16] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/debug.py(48)debug_breakpoint()
-> return wrapped(*args, **kwargs)
(Pdb++) s
--Call--
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(681)_should_update_photo()
-> def _should_update_photo(
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(685)_should_update_photo()
-> export_db = options.export_db
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(686)_should_update_photo()
-> fileutil = options.fileutil
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(688)_should_update_photo()
-> file_record = export_db.get_file_record(dest)
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(690)_should_update_photo()
-> if not file_record:
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(694)_should_update_photo()
-> if options.export_as_hardlink and not dest.samefile(src):
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(698)_should_update_photo()
-> if not options.export_as_hardlink and dest.samefile(src):
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(702)_should_update_photo()
-> if not options.ignore_signature and not fileutil.cmp_file_sig(
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(703)_should_update_photo()
-> dest, file_record.dest_sig
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(702)_should_update_photo()
-> if not options.ignore_signature and not fileutil.cmp_file_sig(
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(708)_should_update_photo()
-> if file_record.export_options != options.bit_flags:
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(715)_should_update_photo()
-> if options.exiftool:
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(716)_should_update_photo()
-> current_exifdata = self._exiftool_json_sidecar(options=options)
(Pdb++) n
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(717)_should_update_photo()
-> return current_exifdata != file_record.exifdata
(Pdb++) n
--Return--
[17] > /Users/rhet/Dropbox/Code/osxphotos/osxphotos/photoexporter.py(717)_should_update_photo()->TrueNotice that in step [17], _should_update_photo returned True and the test immediately preceding was return current_exifdata != file_record.exifdata showing the new exifdata differed from the old exifdata.
Update: You can then hit c to continue the program.
oPromessa
Again, GREEAAATTT JOB!!!!
Describe the bug
--update,--cleanup,--exiftool,--touch-fileoptions I've noticed that a series of files are always re-exported.osxphotosto check.dbandcsvreport file to look for changes on a pic (see analysis below).To Reproduce Steps to reproduce the behavior:
colibri.tomlExpected behavior
Analysis
1969-11-09-1on thecsvfiles from the "last" and the "before last" run produce the same output: exported, updated, exif_updateddbI get the same output for bnoth runs.dbI also get the exact same output for both runs. last and before last.Desktop (please complete the following information):
12.2.1osxphotos --version):0.47.4Additional context Add any other context about the problem here.