RhetTbull / osxphotos

Python app to work with pictures and associated metadata from Apple Photos on macOS. Also includes a package to provide programmatic access to the Photos library, pictures, and metadata.
MIT License
2.17k stars 100 forks source link

Testing on Darwin 12.4 #710

Closed oPromessa closed 2 years ago

oPromessa commented 2 years ago

Is your feature request related to a problem? Please describe. Just updated MacOS to Darwin 12.4. Running the tests of osxphotos similarly to what was done on #636

$ sw_vers 
ProductName:    macOS
ProductVersion: 12.4
BuildVersion:   21F79

Describe the solution you'd like N/A

Describe alternatives you've considered N/A

Additional context

Test results:

$ python3 -m pytest -vv 
============================= test session starts ============================================
platform darwin -- Python 3.9.10, pytest-7.0.1, pluggy-0.13.1 -- /Users/MSP/Documents/GitHub/osxphotos/venv/bin/python3
cachedir: .pytest_cache
rootdir: /Users/MSP/Documents/GitHub/osxphotos, configfile: pytest.ini
plugins: mock-3.7.0
collected 1267 items / 1 skipped / 1266 selected                                                                                                                           

(...)
============================= 1189 passed, 79 skipped in 165.68s (0:02:45) ========================

Additional test: After selecting one photo from my own Library in Photos app.

$ mkdir tmp;  osxphotos export tmp --use-photos-export --selected --verbose
osxphotos version 0.50.3
Using last opened Photos library: /Users/Shared/Pictures/iPhoto Shared Library.photoslibrary
Using export database /Users/MSP/Documents/GitHub/osxphotos/tmp/.osxphotos_export.db
Upgraded export database /Users/MSP/Documents/GitHub/osxphotos/tmp/.osxphotos_export.db from version 6.0 to 7.1
2022-06-03 19:11:38,687 - WARNING - photosdb.py - 112 - WARNING: This module has only been tested with macOS versions [10.12, 10.13, 10.14, 10.15, 10.16, 11.0, 11.1, 11.2, 11.3, 11.4, 11.5, 11.6, 12.0, 12.1, 12.2, 12.3]: you have Darwin, OS version: 12.4
Processing database /Users/Shared/Pictures/iPhoto Shared Library.photoslibrary/database/photos.db
Processing database /Users/Shared/Pictures/iPhoto Shared Library.photoslibrary/database/Photos.sqlite
Database locked, creating temporary copy.
Processing database.
Database version: 6000, 7.
Processing persons in photos.
Processing detected faces in photos.
Processing albums.
Processing keywords.
Processing photo details.
Processing import sessions.
Processing additional photo details.
Processing face details.
Processing photo labels.
Processing EXIF details.
Processing computed aesthetic scores.
Processing comments and likes for shared photos.
Processing moments.
Done processing details from Photos library.
Exporting 1 photo to /Users/MSP/Documents/GitHub/osxphotos/tmp...
Exporting IMG_20211201_132936.JPG (IMG_20211201_132936.JPG) (1/1)
Skipping missing original photo IMG_20211201_132936.JPG (5BEDFA50-0DE7-4F54-B288-E4229C25586A)
Exporting 1 photos ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00
Processed: 1 photo, exported: 0, missing: 1, error: 0
Elapsed time: 0:00:01

Process: Photos [77559] Path: /System/Applications/Photos.app/Contents/MacOS/Photos Identifier: com.apple.Photos Version: 7.0 (450.0.160) Build Info: Photos_Apps-450000160000000~15 Code Type: X86-64 (Native) Parent Process: launchd [1] User ID: 501

Date/Time: 2022-06-03 19:14:52.5539 +0100 OS Version: macOS 12.4 (21F79) Report Version: 12 Anonymous UUID: (...)

Sleep/Wake UUID: (...)

Time Awake Since Boot: 240000 seconds Time Since Wake: 15878 seconds

System Integrity Protection: enabled

Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Exception Type: EXC_BAD_INSTRUCTION (SIGILL) Exception Codes: 0x0000000000000001, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY

Termination Reason: Namespace SIGNAL, Code 4 Illegal instruction: 4 Terminating Process: exc handler [77559] (...)

RhetTbull commented 2 years ago

What happens if you run the same command without --use-photos-export? Maybe related to #625

Are you on Intel or M1? Which terminal app are you using?

oPromessa commented 2 years ago

What happens if you run the same command without --use-photos-export? Maybe related to #625

  • It does not crash with that same pic selected!
    $ osxphotos export tmp  --selected --verbose
    osxphotos version 0.50.3
    Using last opened Photos library: /Users/Shared/Pictures/iPhoto Shared Library.photoslibrary
    Using export database /Users/MSP/Documents/GitHub/osxphotos/tmp/.osxphotos_export.db
    2022-06-03 19:42:33,791 - WARNING - photosdb.py - 112 - WARNING: This module has only been tested with macOS versions [10.12, 10.13, 10.14, 10.15, 10.16, 11.0, 11.1, 11.2, 11.3, 11.4, 11.5, 11.6, 12.0, 12.1, 12.2, 12.3]: you have Darwin, OS version: 12.4
    Processing database /Users/Shared/Pictures/iPhoto Shared Library.photoslibrary/database/photos.db
    Processing database /Users/Shared/Pictures/iPhoto Shared Library.photoslibrary/database/Photos.sqlite
    Database locked, creating temporary copy.
    Processing database.
    Database version: 6000, 7.
    Processing persons in photos.
    Processing detected faces in photos.
    Processing albums.
    Processing keywords.
    Processing photo details.
    Processing import sessions.
    Processing additional photo details.
    Processing face details.
    Processing photo labels.
    Processing EXIF details.
    Processing computed aesthetic scores.
    Processing comments and likes for shared photos.
    Processing moments.
    Done processing details from Photos library.
    Exporting 1 photo to /Users/MSP/Documents/GitHub/osxphotos/tmp...
    Exporting IMG_20211201_132936.JPG (IMG_20211201_132936.JPG) (1/1)
    Exported IMG_20211201_132936.JPG to /Users/MSP/Documents/GitHub/osxphotos/tmp/IMG_20211201_132936.JPG
    Exported /Users/MSP/Documents/GitHub/osxphotos/tmp/IMG_20211201_132936.JPG
    Exporting 1 photos ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00
    Processed: 1 photo, exported: 1, missing: 0, error: 0
    Elapsed time: 0:00:00

    Are you on Intel or M1?

Intel

Which terminal app are you using?

Mac OSX terminal