RhetTbull / osxphotos

Python app to work with pictures and associated metadata from Apple Photos on macOS. Also includes a package to provide programmatic access to the Photos library, pictures, and metadata.
MIT License
2.17k stars 100 forks source link

Testing on Darwin 12.6 #792

Closed oPromessa closed 2 years ago

oPromessa commented 2 years ago

Is your feature request related to a problem? Please describe. Just updated MacOS to Darwin 12.6. Running the tests of osxphotos similarly to what was done on #636, #710 and #753

Describe alternatives you've considered N/A

Additional context

Test Results

$ python3 -m pytest -vv
======================================== test session starts ===================================
platform darwin -- Python 3.9.10, pytest-7.0.1, pluggy-0.13.1 -- /Users/MSP/Documents/GitHub/osxphotos/venv/bin/python3
cachedir: .pytest_cache
rootdir: /Users/MSP/Documents/GitHub/osxphotos, configfile: pytest.ini
plugins: mock-3.7.0, cov-3.0.0
collected 1375 items / 2 skipped / 1373 selected  
(...)

======================================== 1297 passed, 80 skipped in 147.44s (0:02:27) ==============

Additional test: After selecting one photo from my own Library in Photos app.

Process: Photos [85102] Path: /System/Applications/Photos.app/Contents/MacOS/Photos Identifier: com.apple.Photos Version: 7.0 (460.0.120) Build Info: Photos_Apps-460000120000000~36 Code Type: X86-64 (Native) Parent Process: launchd [1] User ID: 501

Date/Time: 2022-09-15 11:06:50.1772 +0100 OS Version: macOS 12.6 (21G115) Report Version: 12 Anonymous UUID: (...)

Sleep/Wake UUID: (...)

Time Awake Since Boot: 100000 seconds Time Since Wake: 1099 seconds

System Integrity Protection: enabled

Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Exception Type: EXC_BAD_INSTRUCTION (SIGILL) Exception Codes: 0x0000000000000001, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY

Termination Reason: Namespace SIGNAL, Code 4 Illegal instruction: 4 Terminating Process: exc handler [85102]

* with the same _problematic_ pic and not using `--use-photos-export` it ran ok and no crash from Photos.
```sh
$ mkdir tmp;  osxphotos export tmp  --selected --verbose
mkdir: tmp: File exists
osxphotos version 0.51.7
Using last opened Photos library: /Users/Shared/Pictures/iPhoto Shared Library.photoslibrary
Using export database /Users/MSP/Documents/GitHub/osxphotos/tmp/.osxphotos_export.db
2022-09-15 11:02:46,135 - WARNING - photosdb.py - 119 - WARNING: This module has only been tested with macOS versions [10.12, 10.13, 10.14, 10.15, 10.16, 11.0, 11.1, 11.2, 11.3, 11.4, 11.5, 11.6, 12.0, 12.1, 12.2, 12.3, 12.4, 12.5]: you have Darwin, OS version: 12.6
Processing database /Users/Shared/Pictures/iPhoto Shared Library.photoslibrary/database/photos.db
Processing database /Users/Shared/Pictures/iPhoto Shared Library.photoslibrary/database/Photos.sqlite
Processing database.
Database version: 6000, 7.
Processing persons in photos.
Processing detected faces in photos.
Processing albums.
Processing keywords.
Processing photo details.
Processing import sessions.
Processing additional photo details.
Processing face details.
Processing photo labels.
Processing EXIF details.
Processing computed aesthetic scores.
Processing comments and likes for shared photos.
Processing moments.
Done processing details from Photos library.
Exporting 1 photo to /Users/MSP/Documents/GitHub/osxphotos/tmp...
Exporting Pic_047(...).jpg (Pic_047_CD000_000_20010504_Baby_Shower.jpg) (1/1)
Exported Pic_047(...).jpg to /Users/MSP/Documents/GitHub/osxphotos/tmp/Pic_047(...).jpg
Exported /Users/MSP/Documents/GitHub/osxphotos/tmp/Pic_047(...).jpg
Exporting 1 photos ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00
Processed: 1 photo, exported: 1, missing: 0, error: 0
Elapsed time: 0:00:00
RhetTbull commented 2 years ago

Great -- thanks! I'll update the compatibility matrix.