RhetTbull / osxphotos

Python app to work with pictures and associated metadata from Apple Photos on macOS. Also includes a package to provide programmatic access to the Photos library, pictures, and metadata.
MIT License
2.15k stars 99 forks source link

Edited photo path is wrong in Mojave #859

Closed RhetTbull closed 1 year ago

RhetTbull commented 1 year ago

Based on debug info provided by @drodner, osxphotos is not always finding editing photos in Mojave and incorrectly reports the edited photos as missing. In at least one example, the folder ID is incorrectly calculated by osxphotos though the file ID is correct.

There is no file at "/Volumes/Photos2/Photos Library.photoslibrary/resources/media/version/19/00/" In fact, the 00 folder doesn't exist either. In the /media/version/19 folder there are 2 folders -- 03 and 04. And they have different images in them.

osxphotos thinks the edited version of a photo should be in:

/Volumes/Photos2/Photos Library.photoslibrary/resources/media/version/19/00/fullsizeoutput_19b14.jpeg

but:

I did a search and found the image. It's located at "/Volumes/Photos2/Photos Library.photoslibrary/resources/media/version/9b/01" And it is indeed the correct edited image, so at least the filename "fullsizeoutput_19b14.jpeg" is correct.

Looks like Photos used chars 1:2 of the file ID instead of expected 0:1 for the folder ID.

  Hi, 

I recently ran an export on a large photos library of roughly 155000 pictures. It's Photos 4.0 on MacOS Mojave. I'm trying to export so I can migrate to digiKam, but I'm seeing a problem with the export of edited images.

In our Photos library, displaying only the Edited photos shows about 5900 pictures. When I ran the export, I only got 250 files with a filename including "_edited"

All of these 250, except for 2, were in a 2019/_ folder -- photos that were not in albums. However, we also have many edited photos that are in albums, and many edited photos from other years as well.

There are many photos that have duplicate file names, especially photos that are not in albums and thus export to an '_' folder. Lots of DSC_0001.JPG for example. Exported files correctly have DSC_0001 (1).JPG, DSC_0001 (2).JPG, etc. But I think maybe edited files are being overwritten, or not all of them exported. In all the cases I've looked at, the DSC_0001_edited.JPG is a very different picture than DSC_0001.JPG. But it does match with one of the DSC_0001 (n) images. I think the edited version was exported without (or before) the original image got the (n) added to its filename, and so the few _edited images I have do not have correct filenames for their corresponding original images.

Wondering if there is a fix for this or if there is something I need to do differently.

Thanks for your help!

Originally posted by @drodner in https://github.com/RhetTbull/osxphotos/discussions/856

RhetTbull commented 1 year ago

@all-contributors please add @drodner for bug, userTesting

allcontributors[bot] commented 1 year ago

@RhetTbull

I've put up a pull request to add @drodner! :tada:

RhetTbull commented 1 year ago

Fixed in v0.55.2