RhinoRhys / radarr-collections

Movie discovery tool for Radarr to follow Movie Collections and People's work.
GNU General Public License v3.0
146 stars 10 forks source link

Not accepting port when baseurl is enabled. #63

Closed Roxedus closed 5 years ago

Roxedus commented 5 years ago

I run a reverse proxy, but prefer to connect to the service internally, so i need to use 7878

fryfrog commented 5 years ago

Ah, this is what I saw! I enabled base url and it was obviously trying to connect to my reverse proxy. So I just "fixed" it by letting it do that. But it should have been able to connect to my actual instance.

RhinoRhys commented 5 years ago

The reverse proxy doesn't need to be set even if you have one running. Using "off" just makes the url host:port whereas putting anything else makes the url host/base_url. It's there because I have my reverse proxy set up to work locally too so I'm accessing mine via mediaserver/film on the local network rather than 192.168.1.250:7878, If you can still access Radarr using the port locally, just leave it as "off" and it should be fine I think?

fryfrog commented 5 years ago

No, because most people set url base directly on their radarr too so that domain.com/radarr and ip:port/radarr work the same.

On Tue, Mar 5, 2019, 2:47 PM RhinoRhys notifications@github.com wrote:

The reverse proxy doesn't need to be set even if you have one running. Using "off" just makes the url host:port whereas putting anything else makes the url host/base_url. It's there because I have my reverse proxy set up to work locally too so I'm accessing mine via mediaserver/film on the local network rather than 192.168.1.250:7878, If you can still access Radarr using the port locally, just leave it as "off" and it should be fine I think?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/RhinoRhys/radarr-collections/issues/63#issuecomment-469890014, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFWxBlU3ll3-Mmg7sEThUU51f85OuHEks5vTvQCgaJpZM4bfg9c .

RhinoRhys commented 5 years ago

Ooooh yeah, I get you now. Yeah I didn't think that through properly, I'll add a True/False switch rather than having it use "off" as the indicator.

RhinoRhys commented 5 years ago

Sorry could you post your traceback please. I'm not having any issues connecting regardless of it being host/radarr/api, host:port/api or host:port/radarr/api.

fryfrog commented 5 years ago

My nginx runs on port 80 and 443, 80 redirects to 443.

radarr = {
          "host" : "10.0.1.2",
          "port": "7878",
          "base_url": "/radarr",
          "api_key" : "<removed>",
}
0 ✓ fryfrog@apollo ~/git/radarr-collections $[master] python2 rcm.py -c
Welcome to Radarr Collection and People Manager by u/RhinoRhys

Traceback (most recent call last):
  File "rcm.py", line 275, in <module>
    data = api("Radarr")
  File "rcm.py", line 134, in api
    response = requests.get(url, params = key )
  File "/usr/lib/python2.7/site-packages/requests/api.py", line 75, in get
    return request('get', url, params=params, **kwargs)
  File "/usr/lib/python2.7/site-packages/requests/api.py", line 60, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 533, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 668, in send
    history = [resp for resp in gen] if allow_redirects else []
  File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 247, in resolve_redirects
    **adapter_kwargs
  File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 646, in send
    r = adapter.send(request, **kwargs)
  File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 514, in send
    raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='10.0.1.2', port=443): Max retries exceeded with url: /radarr/api/movie?apikey=<removed> (Caused by SSLError(CertificateError("hostname '10.0.1.2' doesn't match either of sub.domain.com', 'domain.com', 'www.domain.com'",),))
RhinoRhys commented 5 years ago

Ah crap if it's going through 443 it won't like that it's only http://. Updated