Update Vulnerable Cognito - Githubissues

RhinoSecurityLabs / cloudgoat

CloudGoat is Rhino Security Labs' "Vulnerable by Design" AWS deployment tool

BSD 3-Clause "New" or "Revised" License

2.89k stars 598 forks source link

Update Vulnerable Cognito #213

Closed andrew-aiken closed 1 year ago

andrew-aiken commented 1 year ago

Overview of Changes

Major Changes

Pulling in additional cheat sheet steps from https://github.com/RhinoSecurityLabs/cloudgoat/pull/204
Deprecated resource aws_s3_bucket_object-> aws_s3_object
Remove template_file data call, switched to templatefile() function
Add aws_s3_bucket_public_access_block resource to allow the bucket policy (https://github.com/RhinoSecurityLabs/cloudgoat/issues/187)

Minor Changes

Formatting of Terraform code (terraform fmt)
Linting (used tflint)
Switched from json blobs to Terraform jsonencode
Move inline policies directly onto the role
Remove unused commented out Terraform

Testing

Run thought the scenario in Terraform versions 1.2.0 & 1.5.6 (latest)

jdearmas commented 1 year ago

Hey @andrew-aiken 👋 ,

First and foremost, thank you for taking the time to contribute to Cloudgoat! ☺️ We truly appreciate the effort you've put into this pull request!

I've reviewed your changes and it's clear that you've put a lot of thought and effort into this. It's contributions like yours that make open-source such a vibrant and collaborative community.

Once again, thank you for your dedication and hard work. Looking forward to collaborating further! 👍

Warm regards, John

P.S. Thank you @TeneBrae93 for helping with this pull request as well! 😄