Format code using Black

RhinoSecurityLabs / pacu

The AWS exploitation framework, designed for testing the security of Amazon Web Services environments.

https://rhinosecuritylabs.com/aws/pacu-open-source-aws-exploitation-framework/

BSD 3-Clause "New" or "Revised" License

4.3k stars 689 forks source link

Format code using Black #403

Closed za closed 7 months ago

za commented 8 months ago

Hi,

This is code style feedback. What do you think if the Python code are formatted using Black?

Pros:

consistent style
single point of truth
may attract more contributors as the code is easier to read

Cons:

subjective
opinionated

za commented 7 months ago

Hi @DaveYesland any opinion on this? Just in case you miss the notification although this is not urgent.

DaveYesland commented 7 months ago

Hello, yeah my initial thought is broadly reformatting all files blindly with Black at this time is not the best idea. I agree this is a good tool to use on future contributions and going forward to ensure a consistent styling. But I think at this time without considering this a little more on formatting parameters and time to review and test changes we will not be applying this across all the files in Pacu.