search

Rhizi / rhizi

Connective intelligence
GNU Affero General Public License v3.0
13 stars 3 forks source link

Improve text of delete node warning message #521

Closed Garbash closed 9 years ago

Garbash commented 9 years ago

Replace "You are about to delete a node, are you sure you want to do that?" With: "Delete [list of node titles] and [list title of connections] connections?" If no connections text should be: "Delete [node title]?"

Garbash commented 9 years ago

Tried to delete single node in rhizi.local and got: Uncaught ReferenceError: ids is not defined delete_selection @ selection.js:274(anonymous function) @ Bacon.js:744(anonymous function) @ Bacon.js:2688inTransaction @ Bacon.js:2662 Dispatcher.push @ Bacon.js:1732Dispatcher.handleEvent @ Bacon.js:1784(anonymous function) @ Bacon.js:6(anonymous function) @ Bacon.js:43 jQuery.event.dispatch @ jquery.js:4641elemData.handle @ jquery.js:4309

On Tue, May 5, 2015 at 10:25 AM, alon notifications@github.com wrote:

Closed #521 https://github.com/Rhizi/rhizi/issues/521 via 1ab3ab5 https://github.com/Rhizi/rhizi/commit/1ab3ab57e0b786315d69f86270aec11f3650131d .

— Reply to this email directly or view it on GitHub https://github.com/Rhizi/rhizi/issues/521#event-296955910.

+972-558863023

Garbash commented 9 years ago

Also when trying to delete node with one edge, prompt didn't alert me that edge will be deleted as well

alon commented 9 years ago

closed with recent fixes (probably fb67d553eaf8966d301b7c038e515cd771aa917a)