RhoBott / data_at_reed

A repository to manage the D@R update!
2 stars 0 forks source link

regex patterns reference #23

Closed simonpcouch closed 3 years ago

simonpcouch commented 3 years ago

Went ahead and made some changes and merged @joshyam-k's PR adding the start of a stringr section, but there was one thing I wasn't sure how to best adjust.

https://github.com/simonpcouch/data_at_reed/blob/c642ade574dd4cc3697ecf36e7198e4ba7ea20f5/content/wrangling_data.Rmd#L250-L252

Does "0 or 1" mean the digits 0 or 1, or a string of length 0 or 1? Similar-ish question for the other two entries. Not sure what the best phrasing is there.


NOTES:

To drop in the code chunk above, I just pasted the URL https://github.com/simonpcouch/data_at_reed/blob/c642ade574dd4cc3697ecf36e7198e4ba7ea20f5/content/wrangling_data.Rmd#L250-L252. To generate this kind of URL, check out the GitHub Docs.

Also, if you (Josh, or anyone else) push a commit that addresses this issue, you can include (closes #23) in the commit message or description and this issue will be automatically closed! This is a really nice way to close issues in a way that explicitly links to the code that addressed the issue, but if you do so without also leaving a comment, some will interpret it as terse.