search

RhoInc / Webcharts

Reusable, flexible, interactive charts with JavaScript
MIT License
34 stars 6 forks source link

Search #115

Closed samussiah closed 7 years ago

samussiah commented 7 years ago

Closes #95

jwildfire commented 7 years ago

Found another little bug: Pagination doesn't currently respect the search term. Will look in to a fix now ...

jwildfire commented 7 years ago

OK, all done for now. Leaving "add a note for # of items matching the search term" for a separate issue, since it is easier after a data flow refactor ...

jwildfire commented 7 years ago

@samussiah Think my commits resolved the issues mentioned in my review. Take a look and go ahead and merge if you think it looks ok.