RhoInc / Webcharts

Reusable, flexible, interactive charts with JavaScript
MIT License
34 stars 6 forks source link

Pagination arrow ordering for data listing is incorrect in RhoMAP #169

Closed emmorris closed 6 years ago

emmorris commented 6 years ago

RhoMAP was recently updated to the most recent version of webcharts and there appears to be a bug in the pagination. As you can see below, the double arrow option should be last, but for some reason in RhoMAP it is listed before the single arrow after the page numbers. The arrows before the page numbers still have the correct order. This issue is present in all of the renderers that use webcharts for the data listing: AE Timelines, Safety Histogram, Safety Shift Plot, Codebook, Query Overview, Paneled Outlier Explorer, and Clinical Timelines.

image

If you inspect the element in RhoMAP and the CAT it appears to be coded the same way: image

samussiah commented 6 years ago

Update .right to .wc-right or something.

emmorris commented 6 years ago

There is still an unmerged pull request for CSS conflict changes. We should make sure this gets added to that since I don't believe it was. https://github.com/RhoInc/Webcharts/pull/158