search

RhoInc / Webcharts

Reusable, flexible, interactive charts with JavaScript
MIT License
34 stars 6 forks source link

Update data framework for `chart.marks` #171

Open jwildfire opened 6 years ago

jwildfire commented 6 years ago

Make a copy of each mark group's raw data at chart.marks[n].data.raw[]. This is in addition to the copy already saved at chart.marks[n].values.raw[] (which can be removed in v2.0)

jwildfire commented 6 years ago

Created this thinking that chart.marks needed a better data model. This may still be true, but after looking more closely I'm not 100% convinced. I think the more pressing (and perhaps easier to fix) issue is that that selecting marks for customization in the chart is currently a pain. Going to deal with that first, and then consider whether this issue needs attention.

jwildfire commented 6 years ago

176 makes mark selection easier, so mark customization should be much easier. Backwards compatible updates are tricky, but updated the issue to capture a minor improvement to the mark data.

jwildfire commented 6 years ago

Final verdict: bump this to v2.0.0. Bars and Points are different and transformData() is just too messy to update safely/quickly.