RhoInc / Webcharts

Reusable, flexible, interactive charts with JavaScript
MIT License
34 stars 6 forks source link

Prevent data inheritance in children of chart.wrap and controls.wrap. #188

Closed samussiah closed 6 years ago

samussiah commented 6 years ago

180 creates unwanted data inheritance of the chart/controls object to children of their wraps, e.g. chart.svg, as described in this d3 issue. This data propagation has the unwanted side effect of unexpected brushing behavior in the safety-shift-plot and paneled-outlier-explorer and issues with the controls in the clinical-timelines.

Test notes

dschwentker commented 6 years ago

Tested and passed using webcharts v1.10.0-dev in CAT.