RhoInc / Webcharts

Reusable, flexible, interactive charts with JavaScript
MIT License
34 stars 6 forks source link

Add a workaround for Webcharts All subsetter logic. #236

Closed samussiah closed 5 years ago

samussiah commented 5 years ago

If the filter variable has a value of All Webcharts counts All twice.

Test notes

jwildfire commented 5 years ago

@samussiah Is there an easy fix for this? If so, shall we address along with #238 in v1.11.3?

samussiah commented 5 years ago

Webcharts has logic here that doesn't allow a value of All in the data to filter correctly. It's an edge case and one that can be avoided by replacing All with a different value (Overall, All Records, etc.). More difficult to fix than I figured.

samussiah commented 5 years ago

issue logged to address All subsetter logic in ae-timelines

danedexF5 commented 5 years ago

It works mostly. There is an edge case where updating a field to All can error CRF, CT and PVL. Spencer is aware and there are issues opened for those 3 renderers.