RhoInc / Webcharts

Reusable, flexible, interactive charts with JavaScript

MIT License

34 stars 6 forks source link

moved google font import out of css into js to make it optional #240

Closed pburnsdata closed 5 years ago

pburnsdata commented 5 years ago

Issues

238

Decided to remove font import from css

jwildfire commented 5 years ago

Looks like there is a known issue in jsdom that is causing the tests to fail here. Should be able to figure out a work around (something like this? )... or we could just add a setting instead.

pburnsdata commented 5 years ago

Yeah good point @jwildfire, although ,that workaround looks like they're trying to set the state and looking through the tests... it looks like it's choking even earlier on XMLHttpRequest - might not be available to the mocha headless browser?

pburnsdata commented 5 years ago

Decided to just remove the css font import - seemed like an unnecessary dependency. However, I'm not aware of how much of a difference the font makes. If either of you @jwildfire or @samussiah think it's important we can find away to make this work, just might take some more thinking