RhoInc / Webcharts

Reusable, flexible, interactive charts with JavaScript
MIT License
34 stars 6 forks source link

Avoid selecting SVG elements without class names in updateDataMarks. #248

Open samussiah opened 5 years ago

samussiah commented 5 years ago

for instance in drawBars:

if any custom rect elements are added to these bar groups the new and original elements behave unpredictably

jwildfire commented 4 years ago

Hmm. Makes sense, but also seems like a bit of an edge case, since I'm not sure if we've ever manually added rects to a bargroup. Marking low priority unless you disagree, @samussiah.

I guess easy solution would be to give the webcharts rect objects used in the code above a specific class, and then use it in those selectors. Or better yet, use marks[].rect.