RhoInc / Webcharts

Reusable, flexible, interactive charts with JavaScript

MIT License

34 stars 6 forks source link

Define histogram bins with specified domain. #252

Closed samussiah closed 5 years ago

samussiah commented 5 years ago

rather than with extent of data

Test notes

Open the Webcharts config-tester.
1. Choose histogram in the Chart Configuration dropdown.
2. Add a custom domain to the X-axis Settings: domain: [0,7].
3. Click the Render Chart button.
4. Verify that the number of bars in the histogram remains the same.
5. Choose histogram-domain in the Webcharts Version dropdown.
6. Verify that the number of bars in the histogram decreases. This behavior is desired when the domain is explicitly defined in the chart configuration. Bar widths should be a function of the domain size rather than the range of the data.

emmorris commented 5 years ago

https://rhoinc.github.io/webcharts-tests/config-tester/test-page/

Spencer is going to update the config tester so that we can test out this update. Test notes and config tester updates coming soon.

Updates that are necessary: point to new data file locations and add safety histogram to drop-down

danedexF5 commented 5 years ago

Works in Chrome and FF. Spencer opened an issue to fix IE at some point but not critical so approving.