RhoInc / Webcharts

Reusable, flexible, interactive charts with JavaScript
MIT License
34 stars 6 forks source link

onResize callback running before marks finish renderering/transitioning. #255

Closed samussiah closed 4 years ago

samussiah commented 5 years ago

consider running onResize callback on transition end event.

jwildfire commented 4 years ago

I think this makes sense, but also wonder if there's some chance it would introduce some unexpected behaviour in renderers. Was there a specific use case where we know this was firing too early? Or was it just a general issue you noticed?

samussiah commented 4 years ago

I don't remember where I ran into this 😞 but this might pop up with a huge number of marks that take a long time to render...

samussiah commented 4 years ago

Can't reproduce.