RhoInc / clinical-timelines

clinical events over time by participant
https://rhoinc.github.io/clinical-timelines/test-page/
MIT License
9 stars 4 forks source link

Data export #161

Closed samussiah closed 6 years ago

samussiah commented 6 years ago

Issues

Closes #124 Closes #139 Closes #142

samussiah commented 6 years ago

How do you mean @pburnsdata ? The export should match the currently displayed data, like it should take into account the time range, the selected event types, and the current filters.

pburnsdata commented 6 years ago

@samussiah Yeah, honestly I couldn't replicate what I was seeing earlier for a while, but realized I had opened CAT in IE when I did this so went back to IE and there did seem to be some wonkiness. What's happening is that the current filters aren't always matching the filters that are applied to the csv exports, hasn't happened yet in chrome though... I'll play some more and let you know when I get something reproducible. event type in csv output not matching filters

pburnsdata commented 6 years ago

@samussiah To reproduce: in IE render the chart, export csv, change the filters, click export csv again, and your second csv will still have the filters from the first. Seems to only happen in IE, so not sure if this should just be separate bug?

samussiah commented 6 years ago

Nice catch @pburnsdata Preston. Should be fixed.