RhoInc / clinical-timelines

clinical events over time by participant
https://rhoinc.github.io/clinical-timelines/test-page/
MIT License
9 stars 4 forks source link

Using grouping and date filtering causes graphs to shift left and cover parts of the page #177

Closed dschwentker closed 6 years ago

dschwentker commented 6 years ago

Steps to reproduce:

  1. Use IE
  2. Add at least one y-axis grouping.
  3. Change the Start Date

Chart should then jump to the left and cover the left hand menu options.

image

Test notes

Issue was that the clip-path of the marks was set to url(#1) rather than to the ID of the chart. When a new chart is rendered the ID of the chart increments and the previous clip-path no longer targets the current chart.

dschwentker commented 6 years ago

This is most egregious in IE, but its actually occurring in a much more subtle manner in Firefox and Chrome as well, but it's only shifting over enough to cover the participant IDs, it doesn't jump all the way to the left hand side of the page. (As such, I've edited the title of the issue a little bit.)

image

dschwentker commented 6 years ago

Tested and passed in all browsers.