search

RhoInc / safety-histogram

Histogram showing distribution of lab measures, vital signs and other measures related to safety in clinical trials.
MIT License
1 stars 1 forks source link

Use (or remove) normal range variables #12

Closed jwildfire closed 7 years ago

jwildfire commented 8 years ago

Normal range columns are included in the settings object, but I don't think we use them.

samussiah commented 8 years ago

Normal range underlay added in branch customization.

jwildfire commented 8 years ago

How does the underlay work? What if there are multiple normal ranges used for a given measure?

samussiah commented 8 years ago

Median value: http://bl.ocks.org/samussiah/raw/7fa57bc399f12574866b761c77abc8bf/

Considered mean but figured the most likely normal range is the best.

jwildfire commented 8 years ago

As discussed - consider rendering a low opacity normal range rectangle for each participant.

samussiah commented 8 years ago

http://bl.ocks.org/samussiah/raw/7fa57bc399f12574866b761c77abc8bf/

jwildfire commented 8 years ago

🎆 I like it!

try something likestroke-color:none; fill-color:#ddd; fill-opacity:0.1 on the underlay rects. would also be good to add a footnote explaining that the rectangles are the normal ranges. Finally, might be worth adding a control to show/hide the underlay.

brittsikora commented 8 years ago

Awesome job!

jwildfire commented 7 years ago

Not working in current build for v1.3.0 (see #37). Will de-bug.

jwildfire commented 7 years ago

Values were just wrong in the gist. Basic functionality for the control is fine. Only issue is that the control is visible even when there are no normal ranges to show. Created #38 to deal with that in v1.4.