search

RhoInc / safety-histogram

Histogram showing distribution of lab measures, vital signs and other measures related to safety in clinical trials.
MIT License
1 stars 1 forks source link

Change version from 2.0.0 to 1.3.0 #26

Closed jwildfire closed 7 years ago

jwildfire commented 7 years ago

@samussiah did something in the changes since v1.2.0 break backwards compatability? If not, I'd recommend we change version in package.json from 2.0.0 to 1.3.0.

jwildfire commented 7 years ago

Looks like we moved from a measure_col parameter to a value_col parameter. Both default to "test" but that is still probably enough to break backwards compatability and move to v2.0.0.

jwildfire commented 7 years ago

Going to close this issue and update milestones accordingly.

jwildfire commented 7 years ago

Brain malfunction: measure_col and value_col both still exist and have the same defaults as v1.2 ...

jwildfire commented 7 years ago

Biggest settings change seems to be that sex_col and race_col are no longer active and are instead included in filters along with SITE and VISITN. The site and visit variables may break backwards compatibility with v1.2 since charts created using data sets that don't include those columns will now bomb ...

jwildfire commented 7 years ago

detail_cols setting is new too, but the null default means no backwards compatibility issues.

jwildfire commented 7 years ago

I'm somewhat inclined to have filters default to null and leave it to the user to customize. That would maintain backwards compatibility and be easier to maintain going forward.

jwildfire commented 7 years ago

Created #28 to alter the default filter behavior. With that change, I think we are safe to say backwards compatibility is in tact and call this v1.3.0.

jwildfire commented 7 years ago

Done in branch v1.3.0