search

RhoInc / safety-histogram

Histogram showing distribution of lab measures, vital signs and other measures related to safety in clinical trials.
MIT License
1 stars 1 forks source link

New filter default #35

Closed jwildfire closed 7 years ago

jwildfire commented 7 years ago

Simple commit to resolve #28

jwildfire commented 7 years ago

@samussiah Another minor tweak for your review.

jwildfire commented 7 years ago

@samussiah @brittsikora Once Spencer checks the code, I'll create a couple of examples related to this one for Britt to use for testing.

samussiah commented 7 years ago

Looks good. Question: do we want to sync filter customization across renderers? That is, do we want specify columns and labels (and so on and so forth) or just the columns?

jwildfire commented 7 years ago

Yes - lets standardize and include labels. Is the syntax used here (see below) ok as the standard? I've made a note in the project to remind us to check all of the renderers and make issues as needed. 

    filters: [
        {value_col: 'SITE', label: 'Site'},     
        {value_col: 'VISITN', label: 'Visit'},      
        {value_col: 'SEX', label: 'Sex'},       
        {value_col: 'RACE', label: 'Race'}
],
samussiah commented 7 years ago

Works for me!