RhoInc / safety-histogram

Histogram showing distribution of lab measures, vital signs and other measures related to safety in clinical trials.
MIT License
1 stars 1 forks source link

Regression Testing for Histogram v2.0.0 #37

Closed jwildfire closed 7 years ago

jwildfire commented 7 years ago

Confirm basic functionality and new features are working as expected in examples shown below:

Examples using v2.0.0 Release Candidate

Basic Functionality (Tested every release)

New Functionality (Tested in V2.0.0 only)

brittsikora commented 7 years ago

@jwildfire Please review

jwildfire commented 7 years ago

@brittsikora I suggest creating a list of new functionality to be tested based on the closed issues in the milestone. I also edited the wording a bit in the basic functionality tests.

brittsikora commented 7 years ago

Normal ranges don't seem to show up on this example chart. The example in the issue (#12) is Spencer's block, so I'm wondering if this is all merged together?

jwildfire commented 7 years ago

Thanks, @brittsikora. I'll look in to the normal ranges bug. They should definitely be there.

jwildfire commented 7 years ago

@brittsikora I updated the 2nd gist to show the normal ranges. The first gist remains a bit buggy, but that is documented in #38 and we can resolve in v1.4.

samussiah commented 7 years ago

Merged a minor logic fix for the normal range functionality into v1.3.0.

gist

jwildfire commented 7 years ago

@brittsikora We need to add feature tests for #38 and #22

jwildfire commented 7 years ago

38 is merged in to dev branch. Bumping #22 to v2.1.0