Closed jwildfire closed 7 years ago
@jwildfire Please review
@brittsikora I suggest creating a list of new functionality to be tested based on the closed issues in the milestone. I also edited the wording a bit in the basic functionality tests.
Normal ranges don't seem to show up on this example chart. The example in the issue (#12) is Spencer's block, so I'm wondering if this is all merged together?
Thanks, @brittsikora. I'll look in to the normal ranges bug. They should definitely be there.
@brittsikora I updated the 2nd gist to show the normal ranges. The first gist remains a bit buggy, but that is documented in #38 and we can resolve in v1.4.
Merged a minor logic fix for the normal range functionality into v1.3.0.
@brittsikora We need to add feature tests for #38 and #22
Confirm basic functionality and new features are working as expected in examples shown below:
Examples using v2.0.0 Release Candidate
Basic Functionality (Tested every release)
New Functionality (Tested in V2.0.0 only)
Default Settings
[x] Confirm that the Measure variable is the only filter available
With Filters
[x] (#28, #18) Confirm that the following filters appear in the example (measure, site, visitnum, sex, race)
[x] (#27) Confirm table header resets when a new filter is applied: test by clicking a bar to expand the table, filter on a variable, check that the table header now says "Click a bar for details."
[x] (#8) Confirm that linked table shows consistent set of default columns when filtering
[x] (#20) Confirm # of enrolled/randomized participants is visible in chart header
[x] (#12) Confirm the ability to apply normal ranges by checking the Normal range box: a range rectangle should appear for each participant
[x] (#11) Confirm that the bars are not cut off on either end of the chart
[x] (#38) Confirm that the option to select normal ranges isn't available when the data doesn't include normal ranges