search

RhoInc / safety-histogram

Histogram showing distribution of lab measures, vital signs and other measures related to safety in clinical trials.
MIT License
1 stars 1 forks source link

Precision #75

Closed samussiah closed 6 years ago

samussiah commented 6 years ago

Issues

Closes #6 Closes #22 Closes #29 Closes #74 Closes #76

samussiah commented 6 years ago

@pburnsdata , I just modularized all the code (helps me more easily understand what's going on in each callback). Focus on src/onPreprocess/setXprecision and src/onResize/hideDuplicateXaxisTickLabels. The precision algorithm isn't perfect if you can think of a better one I'd love to hear it.

emmorris commented 6 years ago

Sending back to Spencer for a quick fix for Internet Explorer.

Per David: safety-histogram throws an error in IE when trying to load the most recent commit for the precision PR: https://github.com/RhoInc/safety-histogram/pull/75 Loads fine in Chrome and FF. There might've been some problems initializing the chart. Errors include: TypeError: Object doesn't support property or method 'log10'

samussiah commented 6 years ago

Ready for you @dschwentker .