V2.7.0 - Githubissues

pburnsdata commented 3 years ago

Branch with Spencers changes - created so that I can also commit to the branch before merging to master

danedexF5 commented 3 years ago

148, 149, 151 all passed for me.

danedexF5 commented 3 years ago

Regression Tests

[x] Confirm that the number and percentage of participants is captured above the chart
[x] Confirm that selecting the Measure filter changes the distribution of observations
[x] Confirm that the x-axis filter changes the x-axis to the selected variable
[x] Confirm that entering a value into the Y-axis Lower Limit box and clicking outside of the box updates the lower limit of the y-axis
[x] Confirm that entering a value into the Upper Limit box and clicking outside of the box updates the upper limit of the y-axis
[x] Confirm that selecting the y-axis reset button returns the chart to the default values for that measure
[x] Confirm that checking the "Visits without data" checkbox shows a timepoint for visits with no associated data points
[x] Confirm that unchecking the "Visits without data" checkbox hides the timepoint for visits with no associated data points
[x] Confirm that checking the "Unscheduled visits" checkbox shows a timepont for unscheduled visits and their associated data
[x] Confirm that unchecking the "Unscheduled visits" checkbox hides the timepoint for unscheduled visits and their associated data
[x] Confirm that hovering on a data point displays tooltips for the data point with Subject, value, and visit
[x] Confirm that date can be added to the standard tooltip with these settings: {tooltip_cols: [{label:"Date", value_col:"DT"}]}
[x] Confirm that clicking on a data point applies a dark highlight to all of the participant's data points
[x] Confirm that clicking on a data point opens a detailed listing of a participant's data beneath the chart
[x] Confirm that when clicking a point that overlaps with another point.
[x] Confirm that all marks (points, lines) associated with that participant should highlight.
[x] Confirm that a note should appear beneath the chart detailing which participants have results overlapping with the click mark.
[x] Confirm that hovering over any ID in the note should highlight that participant in the chart above.
[x] Confirm that clicking any ID in the note should highlight that participant in the chart above and display that participant's measures below.
[x] Confirm that with an overlapping point highlighted, changing any control should remove the note but maintain the highlighting of the selected participant.
[x] Confirm that the selected participant is displayed in a dropdown with the current participant selected
[x] Confirm that the listing contains subject-level demographic data (Age, Sex, and Race appear by default, can add other Participant Details if wanted)
[x] Confirm that the listing contains subject-level information about measures and and visits
[x] Confirm that you can change the selected participant via the dropdown and the new subject should be highlighted in the main chart and the small multiples should update to reflect that participant's data.
[x] Confirm that a dropdown labeled Normal range method appears in the controls section with four options: None, LLN-ULN, Standard Deviation, and Quantiles.
[x] Confirm that selecting Standard Deviation displays a text input labeled Number of standard deviations and defaults to 1.96.
[x] Confirm that selecting Quantiles displays two text inputs, one for the lower quantile and one for the upper quantile, labeled Lower quantile and Upper quantile respectively, that default to .05 and .95.
[x] Confirm that the x-axis tick labels change rotation angles depending on the x-axis control variable.
[x] Confirm that a unit variable is appended to each measure in the Measure dropdown.
[x] Confirm that there is a specified unit variable in the form on the left panel of CAT.
[x] Confirm that there are values displayed next to each measure under the specified unit variable in the data set.
[x] Confirm that the chart lines, when the scrolled on, darken significantly. When the user removes his/her cursor from the chart line, it should return to its default state.
[x] Confirm that when clicking the arrows in the y-axis limit inputs, the limits should increment by a reasonable factor of the y-axis range, or roughly 1/15 of the range. For example, if the range is 150 the increment should be 10 and if the range is 1.5 the increment should be .1.
[x] Confirm that the minimum and maximum points are not clipped by the edge of the chart canvas and can be clicked.
[x] Confirm that hovering over a point that overlaps with one or more other points yields an additional line in the tooltip: Number of overlapping point(s) = n.
[x] Confirm that hovering over a point that does not overlap with any other points does not yield an additional line in the tooltip.

Warnings and Notes

[x] Confirm that the right side of the webpage between the controls and the chart a note should appear that details how many records with missing and/or non-numeric results were removed.
[x] Confirm that the test dataset already contains missing records. To test non-numeric records edit ADBDS.csv by adding non-numeric values to the STRESN column.
[x] Confirm that a warning appears in the console when an invalid initially displayed measure is entered, i.e. one that doesn't appear in the data. (Fill in some dummy text in the "Initially Displayed Measure" field in Settings)
[x] Verify that after entering the dummy text in the "Initially Displayed Measure" field and reloading the chart, that the Measure dropdown defaults to an existent measure
[x] Confirm that when entering a valid initially displayed measure but without units, (e.g. Temperature) that a warning appears in the console noting that the specified measure does not include units
[x] After entering the measure and reloading the chart, verify the Measure dropdown defaults to the specified measure with units

Highlighting

[x] Confirm that adding the following block to the Settings input will add custom marks to the chart: { "custom_marks": [ { "per": [ "USUBJID", "VISIT", "TEST", "STRESN" ], "type": "circle", "attributes": { "fill": "red", "fill-opacity": 1, "stroke": "black", "stroke-opacity": 1 }, "radius": 4, "values": { "DY": [ "56", "112", "168", "224", "280", "336" ] } } ] }
[x] Verify that custom marks as well as default marks highlight as expected
[x] Verify that custom marks as well as default marks can be clicked
[x] Verify that custom marks maintain their visual characteristics, e.g. fill, stroke, etc.

Grouping

[x] Add the following snippet: groups: [{value_col: 'ARM',label: 'Treatment Group'},{value_col: 'SEX',label: 'Sex'}] and verify that the chart now has a "Group By" control.
[x] Confirm that the points and lines are colored by the categories of that group, and that a legend appears at the bottom corresponding to the current grouping and colors.
[x] Confirm that when the 'Group by' Control is changed, the chart and legend reflects the new grouping.
[x] Add the following snippet: "filters": [{"value_col": "ARM","label": "Treatment Group","start": "Placebo"}] and verify a filter appears with the name 'Treatment Group' that subsets the data appropriately when used.
[x] Verify that the dropdown for the the filter does not have an "All" option
[x] Verify that on renderering, the chart is already filtered by 'Placebo' and that this is reflected by the drop down

RhoInc / safety-outlier-explorer

V2.7.0 #152