search

RhoInc / web-codebook

A web-based version of the codebook, which generates a concise summary of every variable in a dataset.
https://rhoinc.github.io/web-codebook/test-page/default/
MIT License
11 stars 5 forks source link

Dynamic height and width #118

Open bzkrouse opened 7 years ago

bzkrouse commented 7 years ago

It would be nice if the codebook could adjust to fit in, say, the RStudio viewer. Also, height and width options would be really useful for the R implementation. codebook_issue

jwildfire commented 7 years ago

@bzkrouse Could you add a screenshot of the issue in RStudio

jwildfire commented 7 years ago

Going to put this in v1.3 so that we can discuss, but I'm just not sure how doable this is at this time. I think it would be a pretty major refactor to really do this right and make the tool reactive.

I'm leaning towards having the primary R use case be a fixed-width shiny app/Rstudio add-in instead of the paneled implementation shown below. Users can also always just pop the visualization out in to the web browser if they want to use the html widget. Maybe there is a way to detect the context and just print a message (instead of rendering the cut-off chart) if someone tries to use the tool in the viewer. Created https://github.com/RhoInc/codebook/issues/2.

@bzkrouse @agstn Curious to get your feedback ...

jwildfire commented 7 years ago

@samussiah suggested going from width:1024px to max-width:1024px ... it's worth a shot, but it means we have to change each of the chart objects to be resizable, and I'm not at all confident that is going to go smoothly ...