Refactor loading indicator

RhoInc / web-codebook

A web-based version of the codebook, which generates a concise summary of every variable in a dataset.

https://rhoinc.github.io/web-codebook/test-page/default/

MIT License

11 stars 5 forks source link

Refactor loading indicator #224

Closed jwildfire closed 6 years ago

jwildfire commented 6 years ago

Get rid of /src/codebook/util/indicateLoading.js and implement a solution that doesn't use setInterval()

jwildfire commented 6 years ago

Didn't totally refactor the approach, so we're still using setInterval), but did add some error handling to avoid the spectacular interactive crashes like the one shown in #219. Also changed appearance via css a bit to make it more obvious when load is occurring.

jwildfire commented 6 years ago

Test Notes: Confirm that loading icon appears in upper right hand corner when loading the page, filtering, grouping, etc. Easiest to test with a large data set.

mhickle commented 6 years ago

Pass