RhodiumGroup / docker_images

Docker images for Rhodium's jupyterlab deployments
2 stars 2 forks source link

WIP: Pangeify+octave #104

Closed delgadom closed 4 years ago

delgadom commented 4 years ago

Workflow

Summary

Builds off pangeify PR #102 and adds octave notebook env and octave-worker image.

Downstream PRs:

DO NOT MERGE UNTIL #102 and RhodiumGroup/helm-chart#6 IS MERGED.

Features

delgadom commented 4 years ago

@bolliger32 this is now merged into and superseded by the conda-env-files branch and #102 PR right? Can we close this PR and delete this branch? I think it all works and adds nothing new.

bolliger32 commented 4 years ago

@delgadom correct! closing and deleting now.

bolliger32 commented 4 years ago

actually #102 merges INTO this branch. So I think we should just accept that PR (which will merge into this branch) and then accept this PR (which will merge into master). It's a bit convoluted now but hopefully after we get this massive update PRd we can make smaller changes.