Closed bolliger32 closed 4 years ago
The two stages were important because the build is too long and frequently fails
From: Ian Bolliger notifications@github.com Sent: Tuesday, June 18, 2019 9:52:20 PM To: RhodiumGroup/docker_images Cc: Michael Delgado; Review requested Subject: Re: [RhodiumGroup/docker_images] WIP: Update py (#91)
@bolliger32https://github.com/bolliger32 requested your review on: #91https://github.com/RhodiumGroup/docker_images/pull/91 WIP: Update py.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/RhodiumGroup/docker_images/pull/91?email_source=notifications&email_token=AA4G7UAY522NHS26TW3UO23P3GUPJA5CNFSM4HZFT6FKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSBUXBCI#event-2422829193, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA4G7UBGCF4DTNKZW6XCWCDP3GUPJANCNFSM4HZFT6FA.
The two stages were important because the build is too long and frequently fails
aha i see that now. Will change back.
OK so clawpack tests all passed (including the netcdf test) with this new base image which just pulls netcdf from apt-get, rather than building from source. Since that's way quicker, I think we can merge it in here, which I've done. Now, both notebook and the two worker images have two stages of build. For the workers, the first stage loads netcdf and does the GCS setup. The second stage loads a python or an octave kernel via conda. For the notebook, the two stages are as they were before, except that the first stage also contains some apt-get commands in there. I don't think they will make the build too long (since it's now broken up into 2 stages), but we can confirm depending on how the build does.
If we do go ahead with this, we can archive the other two repos which built netcdf from scratch and were intermediate images
Thanks for wading into the gnarly world of docker deployment! 😝 I could really use some help maintaining this. Let's go through this in person (maybe after this round of coastal work) to take this to the next level! There's a whole lot of painful trial and error (and not a ton of theory/understanding) that went into the current setup so a fresh look, and some shared learning, would be super helpful!
merged into smaller update. closing PR & deleting branch because this is in the way of dev deployments. In general, PRs to master should be made from other branches, not dev (sorry for the weird protocol)
oh sorry this is not merged. but the PR should be made to master, not dev, if we're going to merge this.
Workflow
dev
branch (see notebook and worker dev tags)Summary
Making a bunch of changes to update packages, update python, and remove the dependency on
miniconda3-gfortran-netcdf
andgfortran-netcdf-notebook
repos.Features
miniconda3-gfortran-netcdf
andgfortran-netcdf-notebook
repos by incorporating the netcdf builds into this repo.travis.yml
to remove some duplication